Skip to content

GPUPicker: Fix multiPickAsync return unexpected results in different hardwareScalingLevel #16537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

KallkaGo
Copy link
Contributor

see https://forum.babylonjs.com/t/gpu-multi-picking-issues/58074/2 and https://forum.babylonjs.com/t/gpu-picker-multi-pick-adjust-to-dpr/58091

In multiPickAsync, when the length of the screen coordinate array passed in is greater than 1, it is not processed to adapt to the current DPR, resulting in unexpected results being returned.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 28, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 28, 2025

@deltakosh deltakosh enabled auto-merge (squash) April 28, 2025 17:26
@bjsplat
Copy link
Collaborator

bjsplat commented Apr 28, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 28, 2025

@deltakosh deltakosh merged commit d7fb65b into BabylonJS:master Apr 28, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants