Skip to content

Fix rotation values in GaussianSplattingMesh to use negative values f… #16521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

takeru
Copy link
Contributor

@takeru takeru commented Apr 23, 2025

…or ROT_2 and ROT_3 cases

I noticed that the appearance differs between ply and spz.
It seems that the rot (rotation) of ply needs to be adjusted.

Lego left=ply, right=spz

Before(differ):

https://sandbox.babylonjs.com/?version=8.3.1
image

After(same):
https://sandbox.babylonjs.com/?snapshot=refs/pull/16521/merge
image

Debug

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 23, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 23, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 23, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 23, 2025

@sebavan
Copy link
Member

sebavan commented Apr 23, 2025

Let s check with @CedricGuillemet but I am pretty sure I have seen PRs doing the opposite and it might depend on the file type ?

@sebavan sebavan requested a review from CedricGuillemet April 23, 2025 15:46
@CedricGuillemet
Copy link
Contributor

Let s check with @CedricGuillemet but I am pretty sure I have seen PRs doing the opposite and it might depend on the file type ?

yes, it's a nightmare to fix for 1 file type and not break the others

Copy link
Contributor

@CedricGuillemet CedricGuillemet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Tested fine with .PLY.

@sebavan sebavan merged commit 015d151 into BabylonJS:master Apr 23, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants