Skip to content

Optimization tool for animation #16519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2025
Merged

Optimization tool for animation #16519

merged 3 commits into from
Apr 22, 2025

Conversation

deltakosh
Copy link
Contributor

Test PG: #28JAK6#1

@deltakosh deltakosh requested review from Popov72 and sebavan April 22, 2025 18:25
@bjsplat
Copy link
Collaborator

bjsplat commented Apr 22, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 22, 2025

@ryantrem
Copy link
Member

Are there models where this would not work? Does this help when there are lots of different animatables? Should the Viewer use this?

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 22, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 22, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 22, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 22, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 22, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 22, 2025

@deltakosh
Copy link
Contributor Author

Are there models where this would not work? Does this help when there are lots of different animatables? Should the Viewer use this?

The main option should be pretty straightforward but it stills assume you do not have two animation with different timeline (which is theorically possible)

@deltakosh deltakosh merged commit dcb295b into master Apr 22, 2025
17 checks passed
@deltakosh deltakosh deleted the anim-optims branch April 22, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants