-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Refactor type validation logic for uniformity checks #16493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…before checking for uniformity
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16493/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16493/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16493/merge#BCU1XR#0 |
WebGL2 visualization test reporter: |
Visualization tests for WebGPU |
packages/dev/loaders/src/glTF/2.0/Extensions/KHR_interactivity/declarationMapper.ts
Outdated
Show resolved
Hide resolved
WebGL2 visualization test reporter: |
Visualization tests for WebGPU |
Ensure all input types are defined before checking for uniformity, improving the validation process for input types.
Small fix for PR #16486