Fix for null TypeError in dynamicTexture #16491
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16491/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16491/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16491/merge#BCU1XR#0 |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
It's possible that when rapidly disposing a dynamicTexture, a delayed callback gets ran on the disposed instance, resulting in a TypeError exception caused by accessing a null instance. The specific case that was causing this issue was when
Tools.SetImmediateis used to pend some future work toupdatethe dynamic texture, and by the time this delayed callback was running, the dynamicTexture had already been disposed.The fix here is to early out of the
updatefunction ifthis._textureis already null. This simply avoids dereferencing a null engine when calling_getEngine().updateDynamicTexture(this._texture, ...). In any case,updateDynamicTextureitself already early outs when the texture parameter is null, so it should not change that behavior.