Add volume playwright audio tests #16487
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces volume tests for Playwright audio components while refactoring audio type naming to use "StaticSound" and "StreamingSound" for clarity. It also updates tests to use the new Channel enum and adds a helper for creating an abstract sound with its output node.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/tools/tests/test/audioV2/utils/audioV2.utils.ts | Updates type definitions and adds CreateAbstractSoundAndOutputNodeAsync |
| packages/tools/tests/test/audioV2/* | Updates tests to use "StaticSound", "StreamingSound", and Channel enum instead of raw values |
| packages/tools/babylonServer/public/audiov2-test.js | Refactors sound creation functions, including renaming AddSound to _AddSound and adding _ExpandSource |
Comments suppressed due to low confidence (2)
packages/tools/babylonServer/public/audiov2-test.js:13
- Renaming 'AddSound' to '_AddSound' indicates an intention for this method to be private. Confirm that this change is intentional since external code relying on a public 'AddSound' may be affected.
static _AddSound(sound) {
packages/tools/babylonServer/public/audiov2-test.js:22
- [nitpick] The _ExpandSource function returns the input as-is when it doesn't match a string or an array. Consider whether additional validation or documentation is needed to clarify this behavior.
static _ExpandSource(source) {
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16487/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16487/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16487/merge#BCU1XR#0 |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
No description provided.