-
Notifications
You must be signed in to change notification settings - Fork 235
Adding fix for OBO cache key error in long running OBO with DefaultAuthorizationHeaderProvider #3381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/Microsoft.Identity.Web.TokenAcquisition/DefaultAuthorizationHeaderProvider.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Identity.Web.TokenAcquisition/DefaultAuthorizationHeaderProvider.cs
Show resolved
Hide resolved
tests/Microsoft.Identity.Web.Test/AuthorizationHeaderProviderTests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Web.Test/AuthorizationHeaderProviderTests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Web.Test/AuthorizationHeaderProviderTests.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Identity.Web.TokenAcquisition/DefaultAuthorizationHeaderProvider.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be better to use the new interface that Keegan created:
this way we could return something?
I'm am not sure it is the best way to do it. The returning of the cache key also happens when using the Lets fix this for the customer since it is the currently released behavior and change the design in a follow up PR. I can create a work item. |
Description
Updates the
DefaultAuthorizationHeaderProvider
to update theAcquireTokenOptions.LongRunningWebApiSessionKey
after the token is acquired so that the key can be used in the next OBO call.Fixes #3382