Skip to content

Enabling IdWeb to throw an exception if MSAL indicates that it should not configure the distributed cache #3295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 26, 2025
Merged

Enabling IdWeb to throw an exception if MSAL indicates that it should not configure the distributed cache #3295

merged 10 commits into from
Mar 26, 2025

Conversation

trwalke
Copy link
Member

@trwalke trwalke commented Mar 12, 2025 •
edited
Loading

This PR depends on this MSAL PR and should not be merged until this PR is released.

Enabling IdWeb to throw an exception if MSAL indicates that it should not configure the distributed cache

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

IdWeb will throw an exception if MSAL TokenCacheNotificationArgs indicates that it should not configure the distributed cache and it is configured.

Description

Issue 3304

@trwalke trwalke requested a review from a team as a code owner March 12, 2025 08:08
@trwalke trwalke marked this pull request as draft March 12, 2025 08:08
@trwalke trwalke mentioned this pull request Mar 12, 2025
Merged
1 task
@jennyf19
Copy link
Collaborator

where is the GitHub issue for this?

jmprieur
jmprieur requested changes Mar 14, 2025
View reviewed changes
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've proposed a change to the XML comment
Also please fix the build errors (public API)

@trwalke trwalke marked this pull request as ready for review March 17, 2025 23:04
@trwalke
Copy link
Member Author

trwalke commented Mar 17, 2025

Added issue #3304

@trwalke trwalke marked this pull request as draft March 17, 2025 23:18
@trwalke trwalke marked this pull request as ready for review March 19, 2025 06:31
@trwalke trwalke linked an issue Mar 19, 2025 that may be closed by this pull request
[Feature Request] IdWeb blocks FMI scenarios with a distributed cache #3304
Closed
@bgavrilMS bgavrilMS requested a review from jmprieur March 19, 2025 12:00
jmprieur
jmprieur approved these changes Mar 24, 2025
View reviewed changes
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I proposed a change of name for the error message

@trwalke trwalke merged commit 99ab1ad into master Mar 26, 2025
5 checks passed
@trwalke trwalke deleted the trwalke/BlockDistributedCacheFromMsal branch March 26, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgavrilMS bgavrilMS bgavrilMS approved these changes

@jmprieur jmprieur jmprieur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] IdWeb blocks FMI scenarios with a distributed cache
4 participants
@trwalke @jennyf19 @bgavrilMS @jmprieur