-
Notifications
You must be signed in to change notification settings - Fork 235
Revert: Warning Quality Check Build Task #3172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert: Warning Quality Check Build Task #3172
Conversation
@alexholub113 Can you link to the pipeline that is now passing with this reverted? |
@alexholub113 I suspect you'll have to edit the pipeline for now to target your branch and ensure this fixes as expected I've shared more details in our internal channel. Once there's a passing pipeline run there I'll approve. In the fullness of time we should have that pipeline take a parameter for branch and then have IDWeb PRs run that pipeline as a merge gate |
To test this revert I created OneBranch PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alexholub113 !
Please create a PBI and assign to @kellyyangsong to re-add this check once it no longer breaks the onebranch PR build
Task was created |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
since these changes cause errors in the pipeline it was decided to roll them back temporarily