Skip to content

Conversation

jmprieur
Copy link
Collaborator

@jmprieur jmprieur commented Sep 9, 2024

Work left (addressing PR feedback)

  • Rename the TokenAcquisitionAddInOptions to TokenAcquisitionExtensionOptions
  • Rename the tokenAcquisitionAddInOptionsMonitor variable to tokenAcquisitionExtensionOptionsMonitor, and addInOptions to tokenAcquisitionExtensionOptions in TokenAcquisition.cs
  • Split the delegages/types in the current file TokenAcquisitionAddIn.cs to their own files.
  • For the moment (until we add more extensions), add the events that are not used by the product in a #if FUTURE.
  • Create a better end to end test (using the ExtraParameters, with extension methods to set a Prefix), and adding a prefix in front of the acquired token?

@jmprieur jmprieur marked this pull request as ready for review October 3, 2024 00:14
@jmprieur jmprieur requested a review from a team as a code owner October 3, 2024 00:14
This was referenced Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants