Add X5C to MSAuth POP #2950
Merged
Add X5C to MSAuth POP #2950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
force-pushed
the
bogavril/msauth_x5c
branch
from
36d0f7b to
84f1e98
Compare
bgavrilMS
force-pushed
the
bogavril/msauth_x5c
branch
from
84f1e98 to
2a431f3
Compare
bgavrilMS
commented
Jul 23, 2024
bgavrilMS
commented
Jul 23, 2024
tests/Microsoft.Identity.Web.Test.Common/Mocks/MockHttpMessageHandler.cs
Show resolved
Hide resolved
bgavrilMS
force-pushed
the
bogavril/msauth_x5c
branch
from
2a431f3 to
4013038
Compare
jmprieur
reviewed
Jul 24, 2024
jmprieur
reviewed
Jul 24, 2024
jmprieur
reviewed
Jul 24, 2024
jmprieur
requested changes
Jul 24, 2024
There was a problem hiding this comment.
LGTM
Thanks @bgavrilMS
I left a few questions and suggestions
jmprieur
approved these changes
Jul 24, 2024
keegan-caruso
pushed a commit
that referenced
this pull request
Aug 9, 2024
The changes introduced test instability
Merged
keegan-caruso
added a commit
that referenced
this pull request
Aug 9, 2024
The changes introduced test instability Co-authored-by: Keegan Caruso <[email protected]>
Merged
This was referenced Aug 1, 2025
This was referenced Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2887
Testing: unit