Adjust issuer validation to accept differing paths #5466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avery-Dunn
changed the title
bgavrilMS
reviewed
Sep 9, 2025
tests/Microsoft.Identity.Test.Unit/CoreTests/InstanceTests/GenericAuthorityTests.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
approved these changes
Sep 9, 2025
bgavrilMS
approved these changes
Sep 11, 2025
gladjohn
approved these changes
Sep 11, 2025
trwalke
approved these changes
Sep 11, 2025
This was referenced Sep 26, 2025
This was referenced Sep 29, 2025
This was referenced Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue in the identity web repo exposed a problem in the issuer validation steps: AzureAD/microsoft-identity-web#3450
Originally the validation step would pass if the authority "started with" the issuer, i.e. it matched the scheme, host, and start of the path. However, there are cases where the path could be different but it still represents a valid authority/issuer pair, such as when the authority uses "organizations" but the issuer uses the actual tenant.
While it might be better to use the
authorityAPI instead ofoidcAuthorityin that scenario we don't require it, and as AzureAD/microsoft-identity-web#3450 shows the current validation can be a breaking change.This PR adjust the issuer validation to only check the HTTP scheme and host, and adds a test confirming that behavior. The existing tests should still pass.