Adding WithExtraBodyParameters api #5389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
reviewed
Jul 18, 2025
src/client/Microsoft.Identity.Client.Extensions.Msal/Shared/StorageCreationPropertiesBuilder.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jul 22, 2025
src/client/Microsoft.Identity.Client/ApiConfig/AcquireTokenForClientParameterBuilder.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jul 22, 2025
bgavrilMS
reviewed
Jul 22, 2025
bgavrilMS
reviewed
Jul 29, 2025
src/client/Microsoft.Identity.Client/Extensibility/AcquireTokenForClientBuilderExtensions.cs
Show resolved
Hide resolved
bgavrilMS
approved these changes
Jul 29, 2025
src/client/Microsoft.Identity.Client/ApiConfig/Parameters/AcquireTokenCommonParameters.cs
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Unit/PublicApiTests/ExtraBodyParametersTests.cs
Outdated
Show resolved
Hide resolved
neha-bhargava
approved these changes
Aug 4, 2025
bgavrilMS
approved these changes
Aug 12, 2025
|
This has been approved @trwalke . Merge it? |
# Conflicts: # src/client/Microsoft.Identity.Client/Extensibility/AbstractConfidentialClientAcquireTokenParameterBuilderExtension.cs # src/client/Microsoft.Identity.Client/PublicApi/net462/PublicAPI.Unshipped.txt # src/client/Microsoft.Identity.Client/PublicApi/net472/PublicAPI.Unshipped.txt # src/client/Microsoft.Identity.Client/PublicApi/net8.0-android/PublicAPI.Unshipped.txt # src/client/Microsoft.Identity.Client/PublicApi/net8.0-ios/PublicAPI.Unshipped.txt # src/client/Microsoft.Identity.Client/PublicApi/net8.0/PublicAPI.Unshipped.txt # src/client/Microsoft.Identity.Client/PublicApi/netstandard2.0/PublicAPI.Unshipped.txt
neha-bhargava
approved these changes
Aug 13, 2025
This was referenced Aug 18, 2025
lilyydu
pushed a commit
to microsoft/teams-ai
that referenced
this pull request
Aug 20, 2025
#minor Updated [Azure.Identity](https://github.com/Azure/azure-sdk-for-net) from 1.14.2 to 1.15.0. <details> <summary>Release notes</summary> _Sourced from [Azure.Identity's releases](https://github.com/Azure/azure-sdk-for-net/releases)._ No release notes found for this version range. Commits viewable in [compare view](https://github.com/Azure/azure-sdk-for-net/commits). </details> Updated [Microsoft.Identity.Client](https://github.com/AzureAD/microsoft-authentication-library-for-dotnet) from 4.74.1 to 4.76.0. <details> <summary>Release notes</summary> _Sourced from [Microsoft.Identity.Client's releases](https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/releases)._ ## 4.76.0 ## What's Changed * Removal of `ExperimentalFeatures` flag on `WithMtlsProofOfPossession` API: by @gladjohn in AzureAD/microsoft-authentication-library-for-dotnet#5402 * #5400 Fixing issue that leads to multiple active access tokens in the cache for non-tenanted oidc authority by @andkorsh in AzureAD/microsoft-authentication-library-for-dotnet#5401 * Add Service Fabric token revocation support by @gladjohn in AzureAD/microsoft-authentication-library-for-dotnet#5421 * Update NativeInterop package version to 0.19.4 by @ashok672 in AzureAD/microsoft-authentication-library-for-dotnet#5434 * Adding WithExtraBodyParameters api by @trwalke in AzureAD/microsoft-authentication-library-for-dotnet#5389 * Enable mTLS Proof‑of‑Possession for Client‑Assertion Delegates by @gladjohn in AzureAD/microsoft-authentication-library-for-dotnet#5409 ## New Contributors * @andkorsh made their first contribution in AzureAD/microsoft-authentication-library-for-dotnet#5401 **Full Changelog**: AzureAD/microsoft-authentication-library-for-dotnet@4.74.1...4.76.0 Commits viewable in [compare view](AzureAD/microsoft-authentication-library-for-dotnet@4.74.1...4.76.0). </details> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Aug 25, 2025
This was referenced Sep 8, 2025
Closed
This was referenced Sep 15, 2025
This was referenced Sep 25, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this request
This PR adds a new extensibility API
WithExtraBodyParameters(Dictionary<string, Func<CancellationToken, Task<string>>> extrabodyparams)The body params are in the form of
Dictionary<string, Func<CancellationToken, Task<string>>>because this will give developers an opportunity to provide a delegate to achieve the dictionary value because it is possible that it may change depending on when it is acquired.These parameters are added to the body parameters of the outgoing request and they are added to the cache key. This way, the tokens acquired with these parameters will only be retrieved when the same parameters are provided.
Testing
Unit/Manual
Documentation