Ensure additional cache parameters are persisted in cache serialization #5262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/Microsoft.Identity.Test.Unit/AuthExtension/AuthenticationOperationTests.cs
Outdated
Show resolved
Hide resolved
neha-bhargava
approved these changes
May 2, 2025
bgavrilMS
reviewed
May 3, 2025
tests/Microsoft.Identity.Test.Unit/AuthExtension/AuthenticationOperationTests.cs
Show resolved
Hide resolved
bgavrilMS
approved these changes
May 3, 2025
gladjohn
approved these changes
May 5, 2025
added 3 commits
May 6, 2025 10:07
…ters' into trwalke/FixAdditionalCacheParameters
bgavrilMS
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
#5261
Changes proposed in this request
PersistedCacheParametersneeds to be serialized in the cache JSON Object when storing the cache externally. This is to ensure they can be retrieved the next time the token is acquired from the external cache.Testing
Unit test
Performance impact
Documentation