Reordered the condition for ManagedIdentitySource.MachineLearning to be checked after ManagedIdentitySource.AppService instead of before it. #5079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gladjohn
changed the title
christothes
reviewed
Jan 14, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/ManagedIdentityClient.cs
Show resolved
Hide resolved
gladjohn
force-pushed
the
gladjohn/msi_source_fix
branch
from
0fe05a8 to
21a30e0
Compare
bgavrilMS
reviewed
Jan 14, 2025
tests/Microsoft.Identity.Test.Unit/ManagedIdentityTests/AppServiceTests.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Jan 14, 2025
tests/Microsoft.Identity.Test.Unit/ManagedIdentityTests/AppServiceTests.cs
Show resolved
Hide resolved
bgavrilMS
approved these changes
Jan 14, 2025
bgavrilMS
approved these changes
Jan 14, 2025
|
@bgavrilMS @neha-bhargava @trwalke given that I am addressing a P1 issue I am going to skip Code Coverage checks and merge this in |
tests/Microsoft.Identity.Test.Common/Core/Helpers/ManagedIdentityTestUtil.cs
Show resolved
Hide resolved
neha-bhargava
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5077
This pull request includes updates to the
ManagedIdentityClientto enhance the logic for determining the managed identity source and adds new test methods to cover these changes. The most important changes include reordering the conditions in theGetManagedIdentitySourcemethod, adding a new method to set environment variables for upgrade scenarios, and introducing new test cases for various managed identity sources.Enhancements to managed identity source logic:
src/client/Microsoft.Identity.Client/ManagedIdentity/ManagedIdentityClient.cs: Reordered the conditions in theGetManagedIdentitySourcemethod to check foridentityEndpointandidentityHeaderbeforemsiSecretMachineLearningandmsiEndpoint. [1] [2]New method for setting environment variables:
tests/Microsoft.Identity.Test.Common/Core/Helpers/ManagedIdentityTestUtil.cs: AddedSetUpgradeScenarioEnvironmentVariablesmethod to set environment variables specific to upgrade scenarios.Additional test cases:
tests/Microsoft.Identity.Test.Unit/ManagedIdentityTests/AppServiceTests.cs: Added internal constants for various endpoints and a new data-driven test methodTestAppServiceUpgradeScenarioto validate the managed identity source detection logic for different scenarios. [1] [2]