-
Notifications
You must be signed in to change notification settings - Fork 435
Switch to back to ValidationResult for results when validating a token. #3299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove dependency on Microsoft.Identity.Abstractions
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
For reference, 8.13.0 diff: 8.13.0...brentsch/ValidationResult |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR returns to using ValidationResult
defined in IdentityModel instead of OperationResult
from Microsoft.Identity.Abstractions. This resolves assembly version compatibility issues when different 8.x assemblies have varying versions and removes the dependency on Microsoft.Identity.Abstractions.
Key Changes:
- Replace all
OperationResult<TResult, TError>
usages withValidationResult<TResult, TError>
- Remove dependency on Microsoft.Identity.Abstractions package
- Update all validation method signatures and implementations throughout the codebase
- Remove using statements for Microsoft.Identity.Abstractions
Reviewed Changes
Copilot reviewed 58 out of 58 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
Multiple test files | Updated test method signatures and variable names from OperationResult to ValidationResult |
ValidationResult.cs | New implementation of ValidationResult replacing OperationResult dependency |
ValidationError.cs | Removed inheritance from OperationError |
Multiple validator files | Updated method signatures and return types to use ValidationResult |
Multiple handler files | Updated validation method signatures and implementations |
Project files | Removed Microsoft.Identity.Abstractions package reference |
API files | Updated public API surface to reflect ValidationResult usage |
src/Microsoft.IdentityModel.Tokens/Experimental/Validation/Results/Details/ValidationResult.cs
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Microsoft.IdentityModel.Tokens.csproj
Show resolved
Hide resolved
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
This PR returns to returning ValidationResult defined in IdentityModel.
This resolves issues:
Microsoft.IdentityModel.Tokens
8.13.1 now depend onMicrosoft.Identity.Abstractions
? #3290