-
Notifications
You must be signed in to change notification settings - Fork 433
Add expected Base64UrlEncoder.Decode overload for NET6 and 8 #3250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really sorry about missing the different in returns for the Decode method, Peter. Thank you for noticing and fixing it. The change makes sense to me! I noticed a unit test (unrelated) was failing, so re-ran the job.
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
return Decode(strSpan, output, decodedLength); | ||
} | ||
#elif NET6_0_OR_GREATER | ||
internal static int Decode(ReadOnlySpan<char> strSpan, Span<byte> output) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would think we need to adjust the API files for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be a follow up
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
Fixes #3251
internal static int Decode(ReadOnlySpan<char> strSpan, Span<byte> output)
withint
return type for NET 6 and NET 8.Working notes which can be disregarded (just didn't want to lose them):