-
Notifications
You must be signed in to change notification settings - Fork 432
Exposes publicly override of AadIssuerValidator factory taking a delegate #3244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jmprieur
merged 3 commits into
dev
from
jmprieur/exposeAadIssuerValidatorFactoryWithCacheFunctionPublicly
May 22, 2025
Merged
Exposes publicly override of AadIssuerValidator factory taking a delegate #3244
jmprieur
merged 3 commits into
dev
from
jmprieur/exposeAadIssuerValidatorFactoryWithCacheFunctionPublicly
May 22, 2025
+41
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR exposes the AadIssuerValidator factory method publicly to enable caching functionality for AadIssuerValidator instances. Key changes include:
- Changing the access modifier of GetAadIssuerValidator from internal to public.
- Adding tests to validate that the factory method handles null/empty authorities and enforces caching when a null provider is used.
- Updating the public API specification to include the new public factory method.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/Microsoft.IdentityModel.Validators.Tests/AadIssuerValidatorTests.cs | Added tests to validate input arguments and caching behavior of the AadIssuerValidator factory method. |
| src/Microsoft.IdentityModel.Validators/PublicAPI.Unshipped.txt | Updated to expose the new public factory method in the public API surface. |
| src/Microsoft.IdentityModel.Validators/AadIssuerValidator/AadIssuerValidator.cs | Changed the GetAadIssuerValidator method from internal to public. |
test/Microsoft.IdentityModel.Validators.Tests/AadIssuerValidatorTests.cs
Outdated
Show resolved
Hide resolved
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
…orTests.cs Co-authored-by: Copilot <[email protected]>
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
jennyf19
approved these changes
May 22, 2025
pmaytak
approved these changes
May 22, 2025
This was referenced Jul 22, 2025
This was referenced Sep 8, 2025
This was referenced Sep 15, 2025
This was referenced Sep 25, 2025
This was referenced Oct 3, 2025
This was referenced Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes publicly override of AadIssuerValidator factory taking a delegate
Fixes #3245