-
Notifications
You must be signed in to change notification settings - Fork 433
Switch for metadata refresh to be blocking #3193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll, as per 8.0.1 behavior. This is done through the Switch.Microsoft.IdentityModel.UpdateConfigAsBlocking switch. If set, configuration calls will be blocking on update, and exceptions when requesting new metadata will be returned to the caller
GeoK
reviewed
Apr 4, 2025
src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager_Blocking.cs
Show resolved
Hide resolved
GeoK
previously approved these changes
Apr 4, 2025
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
jennyf19
previously approved these changes
Apr 5, 2025
jmprieur
previously approved these changes
Apr 7, 2025
src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs
Show resolved
Hide resolved
test/Microsoft.IdentityModel.TestUtils/ResetAppContextSwitchesAttribute.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
src/Microsoft.IdentityModel.Tokens/AppContextSwitches.cs:105
- A corresponding boolean property 'UpdateConfigAsBlocking' (similar to 'UseRfcDefinitionOfEpkAndKid') should be implemented to allow proper evaluation of the blocking switch.
AppContext.SetSwitch(UpdateConfigAsBlockingSwitch, false);
src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager_Blocking.cs:71
- [nitpick] Consider reusing a static Random instance or using a thread-safe alternative for jitter calculation to avoid potential issues with seed duplication during rapid successive calls.
TimeSpan _bootstrapRefreshIntervalWithJitter = TimeSpan.FromSeconds(new Random().Next((int)_bootstrapRefreshInterval.TotalSeconds));
src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs
Show resolved
Hide resolved
268e0c2
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
jennyf19
approved these changes
Apr 7, 2025
westin-m
approved these changes
Apr 7, 2025
pmaytak
approved these changes
Apr 8, 2025
This was referenced Jul 22, 2025
This was referenced Aug 27, 2025
This was referenced Sep 3, 2025
This was referenced Sep 15, 2025
This was referenced Sep 22, 2025
This was referenced Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch for metadata refresh to be blocking
Summary of the changes (Less than 80 chars)
Description
Adds the ability for the metadata refresh to be done as a blocking call, as per 8.0.1 behavior.
This is done through the 'Switch.Microsoft.IdentityModel.UpdateConfigAsBlocking'.
If set, configuration calls will be blocking on update, and exceptions when requesting new metadata will be returned to the caller
Fixes #3192