Skip to content

Conversation

@sruke
Copy link
Contributor

@sruke sruke commented Mar 11, 2025

No description provided.

@sruke sruke self-assigned this Mar 11, 2025
@sruke sruke requested a review from a team as a code owner March 11, 2025 23:04
@sruke sruke requested a review from Copilot March 11, 2025 23:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds inline explanations for CodeQL warnings in order to clarify intentional design choices.

  • In SignedHttpRequestUtilities.cs, comments have been added next to settings that disable validation during pop key decryption.
  • In TokenValidationParameters.cs, comments have been added to note that certain values are copied regardless of their truth value, addressing CodeQL warnings.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Microsoft.IdentityModel.Protocols.SignedHttpRequest/SignedHttpRequestUtilities.cs Added inline comments explaining the intentional disabling of validations during pop key decryption.
src/Microsoft.IdentityModel.Tokens/TokenValidationParameters.cs Added inline comments clarifying that specific values are copied as-is to address CodeQL warnings.

@github-actions
Copy link

Summary

Summary
Generated on: 3/11/2025 - 11:17:37 PM
Coverage date: 3/11/2025 - 11:07:32 PM - 3/11/2025 - 11:17:09 PM
Parser: MultiReport (60x Cobertura)
Assemblies: 1
Classes: 7
Files: 2
Line coverage: 80.3% (620 of 772)
Covered lines: 620
Uncovered lines: 152
Coverable lines: 772
Total lines: 483
Branch coverage: 67.8% (228 of 336)
Covered branches: 228
Total branches: 336
Method coverage: Feature is only available for sponsors

Coverage

Microsoft.IdentityModel.JsonWebTokens - 80.3%
Name Line Branch
Microsoft.IdentityModel.JsonWebTokens 80.3% 67.8%
Microsoft.IdentityModel.JsonWebTokens.JwtTokenUtilities 100%
System.Text.RegularExpressions.Generated 80.3% 67.8%
System.Text.RegularExpressions.Generated 80.3% 67.8%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA
DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJweRegex_1
79.2% 68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA
DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJwsRegex_0
81.4% 67.6%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3
CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJweRegex_1
79.2% 68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3
CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJwsRegex_0
81.4% 67.6%

@sruke sruke merged commit a1f94ac into dev Mar 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants