-
Notifications
You must be signed in to change notification settings - Fork 432
Updates CodeQL.yaml to exclude test files #3163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates CodeQL.yaml to adjust exclusion patterns for test-related files.
- Updates the URL comment for guidance.
- Changes the exclusion patterns for test, perf, docs, and samples from glob patterns (e.g., "test/**") to simpler directory patterns (e.g., "test/").
Comments suppressed due to low confidence (2)
CodeQL.yaml:9
- The updated exclusion pattern 'test/' may not recursively exclude files in subdirectories. If the intent is to exclude all test files, consider reverting to or verifying the use of 'test/**'.
- "test/"
CodeQL.yaml:10
- Similarly, the exclusion pattern 'perf/' might not cover nested files within subdirectories. Confirm that this pattern meets the intended exclusion criteria or consider using 'perf/**'.
- "perf/"
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the CodeQL configuration to exclude test files by modifying the exclusion patterns. Key changes include updating the URL reference, changing the exclusion pattern for test files from "test/" to "test", and replacing "perf/" with "benchmark" while simplifying the docs exclusions.
Comments suppressed due to low confidence (1)
CodeQL.yaml:11
- Confirm that replacing 'perf/' with 'benchmark' aligns with the intended directory structure. If 'perf/' was meant to exclude performance test files, ensure that the new identifier 'benchmark' correctly targets the same set of files.
- "benchmark"
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
Updates CodeQL.yaml to exclude test files
Summary of the changes (Less than 80 chars)
Description
{Detail}
Fixes #{bug number} (in this specific format)