Skip to content

Do not set JsonWebToken.SigningKey until signature succeeds #3111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Do not set JsonWebToken.SigningKey until signature succeeds #3111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Microsoft.IdentityModel.JsonWebTokens/JsonWebTokenHandler.ValidateSignature.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,6 @@ internal static ValidationResult<SecurityKey> ValidateSignature(

if (key is not null)
{
jwtToken.SigningKey = key;

// If the key is found, validate the signature.
return ValidateSignatureWithKey(jwtToken, key, validationParameters, callContext);
}
Expand Down Expand Up @@ -314,7 +312,11 @@ private static ValidationResult<SecurityKey> ValidateSignatureWithKey(
ValidateSignature);

if (valid)
{
jsonWebToken.SigningKey = key;

return key;
}
else
return new SignatureValidationError(
new MessageDetail(
Expand Down
3 changes: 3 additions & 0 deletions ...Microsoft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateSignatureTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@ public void ValidateSignature(JsonWebTokenHandlerValidateSignatureTheoryData the

Exception exception = validationError.GetException();
theoryData.ExpectedException.ProcessException(exception, context);

if (jsonWebToken is not null)
Assert.Null(jsonWebToken.SigningKey);
}

TestUtilities.AssertFailIfErrors(context);
Expand Down
Loading