Skip to content

Conversation

@kllysng
Copy link
Contributor

@kllysng kllysng commented Dec 10, 2024

Addresses #1547

Since I was modifying the tests that used AudienceValidationTheoryData, I updated it to include testId parameter in the ctor.

@kllysng kllysng requested a review from a team as a code owner December 10, 2024 01:11
@sruke
Copy link
Contributor

sruke commented Dec 12, 2024

Consider updating the comment on the RequireAudience property.

@kllysng
Copy link
Contributor Author

kllysng commented Dec 13, 2024

Consider updating the comment on the RequireAudience property.

Updated, please let me know it isn't satisfactory

Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @kellyyangsong

@sruke sruke linked an issue Dec 14, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Token validation does not use require audience parameter

4 participants