Skip to content

Conversation

iNinja
Copy link
Contributor

@iNinja iNinja commented Dec 6, 2024

Add logging to the new validation model

This PR introduces .NET's high performance logging to the new validation model.
The aim is to provide a way to log the results after the fact and on demand, instead of logging as we perform the validation.

  • Added Microsoft.Extensions.Logging.Abstractions to Microsoft.IdentityModel.Tokens to access ILogger (version 9.0.0 does not explicitly support dotnet6, so I am using 8.0.2)
  • Added LoggingEventIds to store event ids used by the logging methods in M.IM.Tokens
  • Added logging to ValidationError and ValidatedToken to log the results obtained from ValidateTokenAsync

Part of #2711

@iNinja iNinja requested a review from a team as a code owner December 6, 2024 16:58
Copy link
Contributor

@kllysng kllysng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants