SAML2 new model validation: Signature #2961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

iNinja merged 24 commits into dev from iinglese/new-model-validation-for-saml2-signature

Nov 8, 2024

Contributor

iNinja commented Nov 1, 2024

SAML2 new model validation: Signature

Implemented signature validation for SAML2 tokens using the new validation model
Added comparison tests to ensure the new validation model behaves like the original.

Note: This re-uses the work introduced for SAML in a previous PR and should not be merged before that one.

Resolves #2950

Part of #2711

iNinja added 11 commits

October 31, 2024 16:07


          Added XmlValidationError. Added ValidationError property to XmlValida…

f92bafe

…tionException to provide custom stack traces


          Added alternative versions using ValidationParameters to XML signatur…

b141a1a

…e validations


          Added XmlValidationFailure to ValidationFailureType

9731a37


          Merge branch 'dev' into iinglese/new-model-validation-for-saml-signature

5e106f7


          Added refactored ValidateSignature method to SamlSecurityTokenHandler.

08a2f19

Updated ValidateTokenAsync to call ValidateSignature.


          Added tests to compare signature validation between the legacy and ne…

5fee17a

…w path


          Re-added API lost in merge to InternalAPI.Unshipped.txt

f9aeac7


          Migrated refactored ValidateSignature from SamlSecurityTokenHandler t…

ccae551

…o Saml2SecurityTokenHandler


          Updated Saml2SecurityTokenHandler's ValidateTokenAsync to validate si…

bdb6133

…gnatures


          Added tests

668eae3


          Merge branch 'dev' into iinglese/new-model-validation-for-saml2-signa…

0b505f6

…ture

iNinja marked this pull request as ready for review

November 1, 2024 23:31

iNinja requested a review from a team as a code owner

November 1, 2024 23:31


          Merge branch 'dev' into iinglese/new-model-validation-for-saml2-signa…

0487e34

…ture

This comment was marked as outdated.

Sign in to view


          Merge branch 'dev' into iinglese/new-model-validation-for-saml2-signa…

0dd0f5b

…ture

brentschmaltz reviewed

View reviewed changes

src/Microsoft.IdentityModel.Tokens.Saml/Saml2/Saml2SecurityTokenHandler.ValidateSignature.cs Outdated Show resolved Hide resolved


          Merge branch 'dev' into iinglese/new-model-validation-for-saml2-signa…

3f58a63

…ture

This comment was marked as outdated.

Sign in to view

msbw2 reviewed

View reviewed changes

src/Microsoft.IdentityModel.Tokens.Saml/Saml2/Saml2SecurityTokenHandler.ValidateSignature.cs Outdated Show resolved Hide resolved

msbw2 reviewed

View reviewed changes

src/Microsoft.IdentityModel.Tokens.Saml/Saml2/Saml2SecurityTokenHandler.ValidateSignature.cs Show resolved Hide resolved

msbw2 reviewed

View reviewed changes

src/Microsoft.IdentityModel.Tokens.Saml/Saml2/Saml2SecurityTokenHandler.ValidateSignature.cs Show resolved Hide resolved

msbw2 reviewed

View reviewed changes

src/Microsoft.IdentityModel.Tokens.Saml/Saml2/Saml2SecurityTokenHandler.ValidateSignature.cs Show resolved Hide resolved

msbw2 reviewed

View reviewed changes

src/Microsoft.IdentityModel.Tokens.Saml/Saml2/Saml2SecurityTokenHandler.ValidateSignature.cs Outdated Show resolved Hide resolved

msbw2 reviewed

View reviewed changes

src/Microsoft.IdentityModel.Tokens.Saml/Saml2/Saml2SecurityTokenHandler.ValidateSignature.cs Outdated Show resolved Hide resolved

msbw2 reviewed

View reviewed changes

src/Microsoft.IdentityModel.Tokens.Saml/Saml2/Saml2SecurityTokenHandler.ValidateSignature.cs Outdated Show resolved Hide resolved

msbw2 reviewed

View reviewed changes

src/Microsoft.IdentityModel.Tokens.Saml/Saml2/Saml2SecurityTokenHandler.ValidateSignature.cs Outdated Show resolved Hide resolved

msbw2 reviewed

View reviewed changes

src/Microsoft.IdentityModel.Tokens.Saml/Saml2/Saml2SecurityTokenHandler.ValidateSignature.cs Show resolved Hide resolved

msbw2 reviewed

View reviewed changes

src/Microsoft.IdentityModel.Tokens.Saml/Saml2/Saml2SecurityTokenHandler.ValidateSignature.cs Outdated Show resolved Hide resolved

msbw2 reviewed

View reviewed changes

src/Microsoft.IdentityModel.Tokens.Saml/Saml2/Saml2SecurityTokenHandler.ValidateSignature.cs Show resolved Hide resolved

This was referenced Aug 20, 2025

Bump System.IdentityModel.Tokens.Jwt from 8.0.1 to 8.14.0 statisticssweden/PxWeb#727

Open

Bump System.IdentityModel.Tokens.Jwt from 7.3.1 to 8.14.0 CleveritDemo/AzureSREAgent#1

Open

Bump Azure.Identity and 3 others Ed-Fi-Alliance-OSS/Data-Management-Service#690

Closed

Bump Azure.Identity and 2 others Ed-Fi-Alliance-OSS/Data-Management-Service#694

Closed

Bump System.IdentityModel.Tokens.Jwt from 6.34.0 to 8.14.0 The404Studios/Kenshi-Online#21

Merged

Bump Microsoft.IdentityModel.Tokens from 8.0.1 to 8.14.0 openwallet-foundation-labs/wallet-framework-dotnet#371

Closed

Bump Microsoft.IdentityModel.Tokens and System.IdentityModel.Tokens.Jwt openwallet-foundation-labs/wallet-framework-dotnet#372

Closed

This was referenced Sep 3, 2025

Bump Microsoft.IdentityModel.Tokens from 8.0.1 to 8.14.0 openwallet-foundation-labs/wallet-framework-dotnet#377

Closed

Bump Azure.Identity and 3 others Ed-Fi-Alliance-OSS/Data-Management-Service#703

Closed

Bump System.IdentityModel.Tokens.Jwt from 7.3.1 to 8.14.0 engaliraza/eshop#6

Open

Bump Microsoft.IdentityModel.Tokens from 7.7.1 to 8.14.0 NorskHelsenett/HelseID.Samples#163

Closed

Bump Microsoft.IdentityModel.Tokens and System.IdentityModel.Tokens.Jwt NorskHelsenett/HelseID.Samples#164

Closed

Bump System.IdentityModel.Tokens.Jwt from 7.6.0 to 8.14.0 NorskHelsenett/HelseID.Samples#165

Closed

Bump Microsoft.IdentityModel.Tokens from 8.0.1 to 8.14.0 openwallet-foundation-labs/wallet-framework-dotnet#381

Closed

Bump Microsoft.IdentityModel.Tokens from 7.7.1 to 8.14.0 NorskHelsenett/HelseID.Samples#170

Closed

Bump Microsoft.IdentityModel.Tokens and System.IdentityModel.Tokens.Jwt NorskHelsenett/HelseID.Samples#172

Open

Bump System.IdentityModel.Tokens.Jwt from 7.6.0 to 8.14.0 NorskHelsenett/HelseID.Samples#173

Open

Bump Azure.Identity and 2 others Ed-Fi-Alliance-OSS/Data-Management-Service#708

Closed

Bump Microsoft.IdentityModel.Tokens from 7.7.1 to 8.14.0 NorskHelsenett/HelseID.Samples#179

Open

This was referenced Sep 15, 2025

Bump System.IdentityModel.Tokens.Jwt from 6.34.0 to 8.14.0 pacphi/eShopOnWeb#78

Merged

Bump Azure.Identity and 3 others Ed-Fi-Alliance-OSS/Data-Management-Service#717

Closed

Bump System.IdentityModel.Tokens.Jwt from 6.25.1 to 8.14.0 appsec-devops/VSCodeProjeShop#34

Open

Bump System.IdentityModel.Tokens.Jwt from 6.25.1 to 8.14.0 openwallet-foundation-labs/wallet-framework-dotnet#405

Closed

This was referenced Sep 25, 2025

Bump Azure.Identity and 2 others Ed-Fi-Alliance-OSS/Data-Management-Service#724

Closed

chore: Bump System.IdentityModel.Tokens.Jwt from 7.0.3 to 8.14.0 followthewhiterabbitneo/ARIAredsharpie#17

Open

This was referenced Oct 3, 2025

Bump Azure.Identity and 3 others Ed-Fi-Alliance-OSS/Data-Management-Service#730

Open

chore: Bump System.IdentityModel.Tokens.Jwt from 6.36.0 to 8.14.0 DFE-Digital/get-information-about-pupils#328

Closed

dependabot bot mentioned this pull request

Bump System.IdentityModel.Tokens.Jwt from 8.0.2 to 8.14.0 UvA-FNWI/workflow-api#8

Open

This was referenced Oct 24, 2025

Bump Microsoft.IdentityModel.JsonWebTokens from 5.7.0 to 8.14.0 bervProject/NETCoreAPIBoilerplate#2963

Closed

Bump Microsoft.IdentityModel.JsonWebTokens and System.IdentityModel.Tokens.Jwt bervProject/NETCoreAPIBoilerplate#2971

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet