-
Notifications
You must be signed in to change notification settings - Fork 432
Restore EnsureAotCompatibility test #2951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think this might be a build step. At least it would make sense to be one to me instead of a unit test. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @kellyyangsong
Do we understand why it was skipped in the first place?
@jmprieur yes, thanks for asking, I should have explained in a comment. It was skipped because it would timeout which for this test is taking longer than 3 min in the ADO build. I re-ran this many times and never saw it take longer than 50s to complete. |
We have an analyzer that will cause warnings - but I still think this test is useful until we start treating warnings as errors. |
The test is passing locally without issue. Running an ADO PR build to ensure it passes there too.
Update - test passed in ADO build with no issues, running again
Update again - passed again