Skip to content

Regression tests: Token Type #2932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 24, 2024
Merged

Regression tests: Token Type #2932

merged 11 commits into from
Oct 24, 2024

Conversation

@iNinja
Copy link
Contributor

@iNinja iNinja commented Oct 23, 2024

Regression tests: Token Type

  • Added TokenTypeValidationError to create the exception and assign the invalid token type.
  • Renamed ValidationParameters.TypeValidator to ValidationParameters.TokenTypeValidator
  • Adjusted the creation of SecurityTokenInvalidTypeException to return the correct invalid type when it is empty or null
  • Added regression/comparison tests for token type validation scenarios

Resolves #2914

Part of #2711

@iNinja iNinja requested a review from a team as a code owner October 23, 2024 14:58
kllysng
kllysng requested changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@kllysng kllysng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment regarding the breaking change in ValidationParameters

kllysng
kllysng approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@kllysng kllysng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @iNinja

@iNinja iNinja merged commit aed25ca into dev Oct 24, 2024
5 checks passed
@iNinja iNinja deleted the iinglese/regression-tests-token-type branch November 15, 2024 12:12
@dependabot dependabot bot mentioned this pull request Jul 23, 2025
Closed
This was referenced Aug 6, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
This was referenced Aug 15, 2025
Closed
Closed
This was referenced Aug 20, 2025
Open
Open
Closed
Closed
Merged
Closed
Closed
This was referenced Sep 3, 2025
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
Open
Open
Closed
Open
This was referenced Sep 15, 2025
Merged
Closed
Open
Closed
This was referenced Sep 25, 2025
Closed
Open
This was referenced Oct 3, 2025
Open
Closed
@dependabot dependabot bot mentioned this pull request Oct 14, 2025
Open
This was referenced Oct 24, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kllysng kllysng kllysng approved these changes

@westin-m westin-m westin-m approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add comparison tests for Token Type validation in new validation model

3 participants

@iNinja @kllysng @westin-m