Skip to content

Extensibility tests: Audience #2861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 17, 2024
Merged

Extensibility tests: Audience #2861

merged 8 commits into from
Oct 17, 2024

Conversation

iNinja
Copy link
Contributor

@iNinja iNinja commented Oct 2, 2024 •
edited
Loading

Extensibility tests: Audience

  • Added special exception to ValidationError to handle unknown exception types
  • Added new LogMessage for the case above
  • Added extensibility tests for JWT audience validation

Part of #2711

@iNinja iNinja requested a review from a team as a code owner October 2, 2024 14:29
@iNinja iNinja marked this pull request as draft October 3, 2024 16:49
@iNinja iNinja marked this pull request as ready for review October 16, 2024 13:55
jennyf19
jennyf19 reviewed Oct 16, 2024
View reviewed changes
src/Microsoft.IdentityModel.Tokens/LogMessages.cs
// general
public const string IDX10000 = "IDX10000: The parameter '{0}' cannot be a 'null' or an empty object. ";
public const string IDX10001 = "IDX10001: Invalid argument '{0}'. Argument must be of type '{1}'.";
// TODO: Confirm the wording of this message. Possibly create a wiki page to refer users to for more information.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let make sure we have a tracking GitHub issue, otherwise we might forget. agree on an aka.ms link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2907

jennyf19
jennyf19 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great.
:shipit:

@iNinja iNinja linked an issue Oct 17, 2024 that may be closed by this pull request
Add extensibility tests for Audience validation in JsonWebTokenHandler #2908
Closed
iNinja added 5 commits October 17, 2024 14:43
@iNinja
Addressed PR feedback. Separated theory data for tests into individua…
9602826 
…l objects added to the theorydata object.
@iNinja
Addressed PR comments: removed unnecessary default values from test data
34fb602
@iNinja
Merge branch 'dev' into iinglese/extensibility-tests-audience
4dc4478 
# Conflicts:
#	src/Microsoft.IdentityModel.Tokens/InternalAPI.Unshipped.txt
#	src/Microsoft.IdentityModel.Tokens/Validation/Results/Details/AudienceValidationError.cs
@iNinja
Resolved conflict with IM.Tokens/InternalAPI.Unshipped.txt
1504356
@iNinja
Updated tests after changes in dev
0458ecb
FuPingFranco
FuPingFranco approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@FuPingFranco FuPingFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iNinja iNinja merged commit d88aa8d into dev Oct 17, 2024
6 checks passed
@iNinja iNinja deleted the iinglese/extensibility-tests-audience branch November 15, 2024 12:14
@dependabot dependabot bot mentioned this pull request Jul 23, 2025
Closed
This was referenced Aug 6, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 19, 2025
Merged
Merged
Open
Open
Closed
Closed
This was referenced Aug 26, 2025
Merged
Closed
Closed
This was referenced Sep 3, 2025
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
Open
Open
Closed
Open
This was referenced Sep 15, 2025
Merged
Closed
Open
Closed
This was referenced Sep 25, 2025
Closed
Open
This was referenced Oct 3, 2025
Open
Closed
@dependabot dependabot bot mentioned this pull request Oct 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jennyf19 jennyf19 jennyf19 approved these changes

@FuPingFranco FuPingFranco FuPingFranco approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add extensibility tests for Audience validation in JsonWebTokenHandler

3 participants

@iNinja @jennyf19 @FuPingFranco