Regression tests: Audience #2838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

iNinja merged 15 commits into dev from iinglese/regression-tests-audience

Oct 1, 2024

Contributor

iNinja commented Sep 23, 2024

Regression tests: Audience

Extracted regression tests related to audience to a separate file.
Added extra scenarios for audience related validations.
Fixed audience validation unit tests and renamed variables to improve clarity.

Note: Upcoming PRs will continue to extract the different aspects of regression tests into separate files.

Part of #2711

iNinja added 2 commits

September 23, 2024 14:47


          Fixed audience validator unit tests. Renamed variables to improve cla…

…rity.


          Extracted regression tests related to audience to a separate file. Ad…

76e6b9b

…ded remaining regression tests for audience scenarios.

iNinja requested a review from a team as a code owner

September 23, 2024 13:51

jennyf19 reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Outdated Show resolved Hide resolved

jennyf19 reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Show resolved Hide resolved

jennyf19 reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Show resolved Hide resolved

jennyf19 reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Outdated Show resolved Hide resolved

jennyf19 reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Show resolved Hide resolved

jennyf19 reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Show resolved Hide resolved

jennyf19 reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Show resolved Hide resolved

FuPingFranco reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Outdated Show resolved Hide resolved

FuPingFranco reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Outdated Show resolved Hide resolved

FuPingFranco reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Show resolved Hide resolved

sruke reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Outdated Show resolved Hide resolved

sruke reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs

+                                  {
+                                      TokenValidationParameters = CreateTokenValidationParameters(null),
+                                      ValidationParameters = CreateValidationParameters(null),
+                                      Audience = string.Empty,

Contributor

sruke Sep 24, 2024

nit: Should this be a valid Audience while the Audiences property on TVP or VP is null?

Contributor Author

iNinja Sep 24, 2024

The current validation path considers the case where no valid audiences are provided to be invalid and throws.
The new validation path took that as a base and kept the same behaviour.

If you believe that having no valid audiences should be considered the same as skipping the validation, we can look into it and find out what the correct behaviour would be.


          Remove whitespace

8d2dba3

brentschmaltz reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Show resolved Hide resolved

brentschmaltz reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Show resolved Hide resolved

brentschmaltz reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Outdated Show resolved Hide resolved

brentschmaltz reviewed

View reviewed changes

...ft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.cs Outdated Show resolved Hide resolved

iNinja added 8 commits

September 26, 2024 13:01


          Cherry picked common functionality extraction from Lifetime branch

2f98fc7


          Added AudienceValidationError to handle custom exception properties

c3ee1e7


          Added delegates to skip validations

cef517e


          Removed token signing from audience validation tests, skipping all va…

57079d9

…lidations but audience


          Merge branch 'dev' into iinglese/regression-tests-audience

f0ea745


          Updated validation delegate names

dd83685


          Updated header being written in tests

b6c4385


          Merge branch 'dev' into iinglese/regression-tests-audience

d518e5f

brentschmaltz reviewed

View reviewed changes

src/Microsoft.IdentityModel.Tokens/Validation/Results/Details/AudienceValidationError.cs Outdated Show resolved Hide resolved

brentschmaltz reviewed

View reviewed changes

src/Microsoft.IdentityModel.Tokens/Validation/Validators.SkipValidations.cs Outdated Show resolved Hide resolved

This was referenced Aug 19, 2025

Bump Microsoft.IdentityModel.Tokens and System.IdentityModel.Tokens.Jwt The404Studios/Kenshi-Online#18

Merged

Bump Microsoft.IdentityModel.Tokens from 6.34.0 to 8.14.0 The404Studios/Kenshi-Online#19

Merged

Bump System.IdentityModel.Tokens.Jwt from 8.0.1 to 8.14.0 statisticssweden/PxWeb#727

Open

Bump System.IdentityModel.Tokens.Jwt from 7.3.1 to 8.14.0 CleveritDemo/AzureSREAgent#1

Open

Bump Azure.Identity and 3 others Ed-Fi-Alliance-OSS/Data-Management-Service#690

Closed

Bump Azure.Identity and 2 others Ed-Fi-Alliance-OSS/Data-Management-Service#694

Closed

This was referenced Aug 26, 2025

Bump System.IdentityModel.Tokens.Jwt from 6.34.0 to 8.14.0 The404Studios/Kenshi-Online#21

Merged

Bump Microsoft.IdentityModel.Tokens from 8.0.1 to 8.14.0 openwallet-foundation-labs/wallet-framework-dotnet#371

Closed

Bump Microsoft.IdentityModel.Tokens and System.IdentityModel.Tokens.Jwt openwallet-foundation-labs/wallet-framework-dotnet#372

Closed

This was referenced Sep 3, 2025

Bump Microsoft.IdentityModel.Tokens from 8.0.1 to 8.14.0 openwallet-foundation-labs/wallet-framework-dotnet#377

Closed

Bump Azure.Identity and 3 others Ed-Fi-Alliance-OSS/Data-Management-Service#703

Closed

Bump System.IdentityModel.Tokens.Jwt from 7.3.1 to 8.14.0 engaliraza/eshop#6

Open

Bump Microsoft.IdentityModel.Tokens from 7.7.1 to 8.14.0 NorskHelsenett/HelseID.Samples#163

Closed

Bump Microsoft.IdentityModel.Tokens and System.IdentityModel.Tokens.Jwt NorskHelsenett/HelseID.Samples#164

Closed

Bump System.IdentityModel.Tokens.Jwt from 7.6.0 to 8.14.0 NorskHelsenett/HelseID.Samples#165

Closed

Bump Microsoft.IdentityModel.Tokens from 8.0.1 to 8.14.0 openwallet-foundation-labs/wallet-framework-dotnet#381

Closed

Bump Microsoft.IdentityModel.Tokens from 7.7.1 to 8.14.0 NorskHelsenett/HelseID.Samples#170

Closed

Bump Microsoft.IdentityModel.Tokens and System.IdentityModel.Tokens.Jwt NorskHelsenett/HelseID.Samples#172

Open

Bump System.IdentityModel.Tokens.Jwt from 7.6.0 to 8.14.0 NorskHelsenett/HelseID.Samples#173

Open

Bump Azure.Identity and 2 others Ed-Fi-Alliance-OSS/Data-Management-Service#708

Closed

Bump Microsoft.IdentityModel.Tokens from 7.7.1 to 8.14.0 NorskHelsenett/HelseID.Samples#179

Open

This was referenced Sep 15, 2025

Bump System.IdentityModel.Tokens.Jwt from 6.34.0 to 8.14.0 pacphi/eShopOnWeb#78

Merged

Bump Azure.Identity and 3 others Ed-Fi-Alliance-OSS/Data-Management-Service#717

Closed

Bump System.IdentityModel.Tokens.Jwt from 6.25.1 to 8.14.0 appsec-devops/VSCodeProjeShop#34

Open

Bump System.IdentityModel.Tokens.Jwt from 6.25.1 to 8.14.0 openwallet-foundation-labs/wallet-framework-dotnet#405

Closed

This was referenced Sep 25, 2025

Bump Azure.Identity and 2 others Ed-Fi-Alliance-OSS/Data-Management-Service#724

Closed

chore: Bump System.IdentityModel.Tokens.Jwt from 7.0.3 to 8.14.0 followthewhiterabbitneo/ARIAredsharpie#17

Open

This was referenced Oct 3, 2025

Bump Azure.Identity and 3 others Ed-Fi-Alliance-OSS/Data-Management-Service#730

Open

chore: Bump System.IdentityModel.Tokens.Jwt from 6.36.0 to 8.14.0 DFE-Digital/get-information-about-pupils#328

Closed

dependabot bot mentioned this pull request

Bump System.IdentityModel.Tokens.Jwt from 8.0.2 to 8.14.0 UvA-FNWI/workflow-api#8

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kllysng kllysng left review comments

jennyf19 jennyf19 approved these changes

FuPingFranco FuPingFranco approved these changes

+2 more reviewers

brentschmaltz brentschmaltz left review comments

sruke sruke left review comments

Labels

None yet