Skip to content

Conversation

iNinja
Copy link
Contributor

@iNinja iNinja commented Sep 6, 2024

New token validation path: Renamed result types

Updated the type names for the new token validation path to prevent future clashes with the type name "Result".

ValidationResult -> ValidatedToken
ExceptionDetails -> ValidationError
Result -> ValidationResult

Validators and delegates now return ValidationResult.
ValidateTokenAsync now returns ValidationResult<ValidatedToken>
Failed validations now return a ValidationError within UnwrapError()

Part of #2711

ValidationResult -> ValidatedToken
ExceptionDetails -> ValidationError
Result -> ValidationResult
@iNinja iNinja requested a review from a team as a code owner September 6, 2024 15:49
@iNinja
Copy link
Contributor Author

iNinja commented Sep 6, 2024

Git did a whole mess due to the fact that I renamed a different file to the name that a previous one had. So now it is comparing OldA against newB.

This PR made no changes to the renamed types, only to the references in other files.

@brentschmaltz brentschmaltz merged commit 5ba278b into dev Sep 9, 2024
5 checks passed
@iNinja iNinja deleted the iinglese/update-result-names branch November 15, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants