-
Notifications
You must be signed in to change notification settings - Fork 434
ValidateTokenAsync - New Path: Refactor result types #2794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cWithVPTests.cs Co-authored-by: Keegan Caruso <[email protected]>
Adding Result and Unit type. Experiment around allocations and performance.
…sult return values to use implicit initialisation
…dated tests for Algorithm and Audience validation
…es to failures, added initial cache experiment for stack frames
jennyf19
reviewed
Aug 26, 2024
jennyf19
reviewed
Aug 26, 2024
src/Microsoft.IdentityModel.JsonWebTokens/JsonWebTokenHandler.DecryptToken.cs
Show resolved
Hide resolved
jennyf19
reviewed
Aug 26, 2024
src/Microsoft.IdentityModel.JsonWebTokens/JsonWebTokenHandler.DecryptToken.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Aug 26, 2024
src/Microsoft.IdentityModel.JsonWebTokens/JsonWebTokenHandler.ValidateSignature.cs
Show resolved
Hide resolved
jennyf19
reviewed
Aug 26, 2024
src/Microsoft.IdentityModel.JsonWebTokens/JsonWebTokenHandler.ValidateSignature.cs
Show resolved
Hide resolved
jennyf19
reviewed
Aug 26, 2024
src/Microsoft.IdentityModel.JsonWebTokens/JwtTokenUtilities.DecryptTokenResult.cs
Outdated
Show resolved
Hide resolved
This was referenced Aug 7, 2025
Bump Microsoft.IdentityModel.Protocols.OpenIdConnect from 8.0.1 to 8.13.0
statisticssweden/PxWeb#693
Closed
This was referenced Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValidateTokenAsync - New Path: Refactor result types
Refactored Result types to reduce allocations and improve performance.
Description
Result<ValidationResult, ExceptionDetail>
fromTokenValidationAsync
to limitValidationResult
to only success scenarios, simplifying scenarios like creating and accessing the ClaimsIdentity.Next steps after this:
Benchmarks for this work:
Sample exception message + stack trace generated with the new stack frames:
Part of #2711