Skip to content

Remove Delegate Checks Audience Validator and Prevents Null Setting of Delegate #2758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 6, 2024
Merged

Remove Delegate Checks Audience Validator and Prevents Null Setting of Delegate #2758

merged 3 commits into from
Aug 6, 2024

Conversation

@FuPingFranco
Copy link
Contributor

@FuPingFranco FuPingFranco commented Jul 31, 2024 •
edited
Loading

Remove Delegate Checks Audience Validator and Prevents Null Setting of Delegate.

Description

  • Removed delegate checks from Audience validation.
  • Moved away from using TokenValidationParameters in favor of the new ValidationParameters.
  • Updated unit tests and added new tests in ValidationParameters class.
  • Fixed minor inconsistencies on the code.

@FuPingFranco FuPingFranco requested a review from a team as a code owner July 31, 2024 21:32
@FuPingFranco FuPingFranco changed the title Remove Delegate Checks in Default Audience Validator and Prevents Null Setting of Delegates Remove Delegate Checks Audience Validator and Prevents Null Setting of Delegate Jul 31, 2024
iNinja
iNinja reviewed Jul 31, 2024
View reviewed changes
jennyf19
jennyf19 approved these changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

iNinja
iNinja approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@iNinja iNinja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change, then looks good.

brentschmaltz
brentschmaltz previously requested changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@brentschmaltz brentschmaltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove 'Set' from properties that return an IList

@FuPingFranco @iNinja
Address PR feedback. (#2765)
0cc32fc 
* Addressed PR feedback. Updated tests

* Removed exception from documentation

* Updated TokenType tests

---------

Co-authored-by: Ignacio Inglese <[email protected]>
@FuPingFranco FuPingFranco dismissed brentschmaltz’s stale review August 6, 2024 15:20

Changes have been implemented, need to dismiss review to unblock work ahead.

@FuPingFranco FuPingFranco merged commit c6f83c4 into dev Aug 6, 2024
@dependabot dependabot bot mentioned this pull request Jul 23, 2025
Closed
This was referenced Aug 6, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 15, 2025
Closed
Closed
Closed
Closed
This was referenced Aug 19, 2025
Merged
Open
Open
Closed
Closed
This was referenced Aug 26, 2025
Merged
Closed
Closed
This was referenced Sep 3, 2025
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
Open
Open
Closed
Open
This was referenced Sep 15, 2025
Merged
Closed
Open
Closed
This was referenced Sep 25, 2025
Closed
Open
This was referenced Oct 3, 2025
Open
Closed
This was referenced Oct 24, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jennyf19 jennyf19 jennyf19 approved these changes

+2 more reviewers

@brentschmaltz brentschmaltz brentschmaltz left review comments

@iNinja iNinja iNinja approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@FuPingFranco @iNinja @brentschmaltz @jennyf19