Skip to content

Conversation

westin-m
Copy link
Contributor

Store the original string the JsonWebKeySet was created with

@westin-m westin-m requested a review from a team as a code owner July 30, 2024 22:44
@pmaytak
Copy link
Contributor

pmaytak commented Jul 31, 2024

Just for my understanding, what's the reasoning for keeping the original string? When would it ever be used for, if it's already parsed into properties?

Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@westin-m
Copy link
Contributor Author

westin-m commented Aug 1, 2024

Just for my understanding, what's the reasoning for keeping the original string? When would it ever be used for, if it's already parsed into properties?

@pmaytak The original string can be used by the OIDC config manager to, on L2 cache reads, deserialize and store the keys alongside the metadata document without needing the JWKs to serialize the security keys

@pmaytak
Copy link
Contributor

pmaytak commented Aug 1, 2024

Just for my understanding, what's the reasoning for keeping the original string? When would it ever be used for, if it's already parsed into properties?

@pmaytak The original string can be used by the OIDC config manager to, on L2 cache reads, deserialize and store the keys alongside the metadata document without needing the JWKs to serialize the security keys

@westin-m But we can add additional keys and remove keys from Keys collection. So is there a benefit then to keeping the original JSON string if it can get out of sync? If we're serializing the key set, we'd want to serialize the current Keys always anyway?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants