Skip to content

Decrypt token: Remove exceptions + use new ValidationParameters #2729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 30, 2024

Conversation

iNinja
Copy link
Contributor

@iNinja iNinja commented Jul 17, 2024

Decrypt token: Remove exceptions + use new ValidationParameters

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • If any gains or losses in performance are possible, you've included benchmarks for your changes. More info
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

  • Added new TokenDecryptingResult
  • Added missing delegate for ValidateAlgorithm
  • Updated ValidationParameters to provide the delegates required for token decryption
  • Refactored DecryptToken method and dependencies to not throw exceptions and return result type.

Raising this as a draft PR to discuss the approach and validate the plan.
I will add tests before making it official.

Part of #2711.

iNinja added 2 commits July 17, 2024 15:45
… understand its use and potential for exception throwing if used wrong.
@iNinja iNinja marked this pull request as ready for review July 23, 2024 16:56
@iNinja iNinja requested a review from a team as a code owner July 23, 2024 16:56
@iNinja iNinja requested a review from brentschmaltz July 23, 2024 16:56
@iNinja iNinja deleted the iinglese/decrypt-token-validation-parameters branch November 15, 2024 12:16
This was referenced Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants