Skip to content

Conversation

@iNinja
Copy link
Contributor

@iNinja iNinja commented Jul 17, 2024

Decrypt token: Remove exceptions + use new ValidationParameters

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • If any gains or losses in performance are possible, you've included benchmarks for your changes. More info
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

  • Added new TokenDecryptingResult
  • Added missing delegate for ValidateAlgorithm
  • Updated ValidationParameters to provide the delegates required for token decryption
  • Refactored DecryptToken method and dependencies to not throw exceptions and return result type.

Raising this as a draft PR to discuss the approach and validate the plan.
I will add tests before making it official.

Part of #2711.

iNinja added 2 commits July 17, 2024 15:45
… understand its use and potential for exception throwing if used wrong.
@iNinja iNinja marked this pull request as ready for review July 23, 2024 16:56
@iNinja iNinja requested a review from a team as a code owner July 23, 2024 16:56
@iNinja iNinja requested a review from brentschmaltz July 23, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants