Skip to content

Make CollectionUtilities.IsNullOrEmpty internal #2699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 11, 2024
Merged

Make CollectionUtilities.IsNullOrEmpty internal #2699

merged 4 commits into from
Jul 11, 2024

Conversation

pmaytak
Copy link
Contributor

@pmaytak pmaytak commented Jul 11, 2024 •
edited
Loading

Fixes #2651, #1722.

  • Make the class and method internal.
  • Make them visible to the SAML tests project.
  • This extension method can actually be called on a string. Updated to use string.IsNullOrEmpty instead since it should be faster (uses Length property instead of .Any()).

@pmaytak pmaytak changed the title Make IsNullOrEmpty internal Make CollectionUtilities.IsNullOrEmpty internal Jul 11, 2024
@pmaytak pmaytak marked this pull request as ready for review July 11, 2024 02:50
@pmaytak pmaytak requested a review from a team as a code owner July 11, 2024 02:50
@pmaytak pmaytak marked this pull request as draft July 11, 2024 02:55
@pmaytak pmaytak linked an issue Jul 11, 2024 that may be closed by this pull request
Conflict with Microsoft.IdentityModel.Tokens.CollectionUtilities.IsNullOrEmpty extension #1722
Closed
@pmaytak pmaytak marked this pull request as ready for review July 11, 2024 07:54
jennyf19
jennyf19 approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pmaytak pmaytak merged commit 3b3d3ec into dev Jul 11, 2024
@pmaytak pmaytak deleted the pmaytak/isnullorempty branch July 11, 2024 17:39
@wtgodbe wtgodbe mentioned this pull request Jul 17, 2024
Merged
@kgerasimov-st kgerasimov-st mentioned this pull request Aug 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jennyf19 jennyf19 jennyf19 approved these changes

@keegan-caruso keegan-caruso keegan-caruso approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Extension method IsNullOrEmpty is public Conflict with Microsoft.IdentityModel.Tokens.CollectionUtilities.IsNullOrEmpty extension

3 participants

@pmaytak @jennyf19 @keegan-caruso