Perform AOT check on repository #2598
Conversation
.github/workflows/aot-check.yml
Outdated
|
|
||
| strategy: | ||
| matrix: | ||
| language: [ 'csharp' ] |
There was a problem hiding this comment.
what's this for? Is it used?
There was a problem hiding this comment.
This was copied from another yml file and was unused. I have removed it.
.github/workflows/aot-check.yml
Outdated
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 2 |
There was a problem hiding this comment.
I have changed the fetch depth to 1 so it fetches the top commit only.
.github/workflows/aot-check.yml
Outdated
|
|
||
| on: | ||
| push: | ||
| branches: [ "dev", "dev6x" ] |
There was a problem hiding this comment.
Is the script going to be checked into dev6x? I didn't think that version was AOT compatible. I think we did all the work in v7.
There was a problem hiding this comment.
Yes, that's correct, good point @eerhardt
There was a problem hiding this comment.
I have removed the dev6x branch.
build/test-aot.ps1
Outdated
|
|
||
|
|
||
|
|
||
|
|
||
|
|
build/test-aot.ps1
Outdated
| Write-Host $publishOutput | ||
| } | ||
|
|
||
| #$runtime = if ($IsWindows) { "win-x64" } elseif ($IsMacOS) { "macos-x64"} else {"linux-x64"} |
There was a problem hiding this comment.
Can we keep the script able to run on all 3 OSes? That way devs can run the script locally without having to move to a specific OS.
There was a problem hiding this comment.
I have restored the checks.
There was a problem hiding this comment.
LGTM. Thanks!
We can also delete https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/tree/dev/test/Microsoft.IdentityModel.AotCompatibility.Tests now since this replaces those tests. We can do that in this PR or in a follow up.
5 participants
Perform AOT check on repository
Summary of the changes
Added a script and yml file to perform AOT check on repository for every pull request. This script will notify us if a non AOT compatible change is added to the repo.