This repository was archived by the owner on Nov 13, 2024. It is now read-only.
Add new variable use_for_each
so we can use for_each
to create multiple resource instances.
#92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This module was created before Terraform introduce
for_each
, and according to the document:Since the
azurerm_subnet
resources were created fromvar.subnet_names
and these subnets are not identical, we should usefor_each
instead ofcount
. But for the users that already maintained existing resources by this module, migrate fromcount
tofor_each
requires heavy manually state move operations with extremely caution.This pull request replicated a new
azurerm_subnet
which usedfor_each
, and we provide a new toggle variable nameduse_for_each
, this toggle is a switcher betweencount
set andfor_each
set. Now user can setvar.use_for_each
totrue
to usefor_each
, and users who're maintaining existing resources could keep this togglefalse
to avoid potential breaking change.Issue number
#000
Checklist before requesting a review
CHANGELOG.md
fileThanks for your cooperation!