Skip to content

Conversation

rbtr
Copy link

@rbtr rbtr commented Aug 7, 2025

to capture granular CNI invocation latency as measured by containerd

containerd metric collection can be seen occuring here: https://dev.azure.com/akstelescope/telescope/_build/results?buildId=31371&view=logs&j=a0a6cafc-0d48-509a-6124-e27fd97b3757&t=d5aa99fe-d00f-5192-5a67-b1b4a85db24b&l=3898

@Copilot Copilot AI review requested due to automatic review settings August 7, 2025 19:28
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds containerd metrics collection capability to CNI benchmark tests to capture granular CNI invocation latency as measured by containerd. The change enables detailed performance monitoring of container runtime network operations.

Key changes:

  • Enables containerd metrics scraping alongside existing kubelet metrics
  • Updates clusterloader2 image version to support new containerd monitoring features
  • Adds new measurement configuration for containerd network operation metrics

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File Description
pipelines/perf-eval/CNI Benchmark/cni-ab-testing.yml Enables scrape_containerd: True for all test configurations and updates clusterloader2 image version
modules/python/clusterloader2/cri/cri.py Adds scrape_containerd parameter throughout the pipeline functions and command-line interface
modules/python/clusterloader2/cri/config/containerd-measurement.yaml New measurement configuration file defining Prometheus queries for containerd CNI metrics
modules/python/clusterloader2/cri/config/config.yaml Integrates containerd measurements into the test configuration workflow

@rbtr rbtr force-pushed the rbtr/pod-slo-containerd-metrics branch 5 times, most recently from 57d2f01 to aa29e21 Compare August 7, 2025 21:52
@rbtr rbtr force-pushed the rbtr/pod-slo-containerd-metrics branch from aa29e21 to e884eff Compare August 8, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant