enforce .zip extension on download item #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Error
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Error
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Error
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Failure
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Error
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Error
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Error
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Error
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Failure
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Failure
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Error
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Error
zijchen
approved these changes
Mar 3, 2023
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Error
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Error
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Error
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Failure
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Error
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Error
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Error
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Error
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Error
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Error
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Error
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Failure
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Error
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Error
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Error
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Error
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Error
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Failure
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Error
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Error
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Error
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Error
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Error
dzsquared
had a problem deploying
to
Automation test
GitHub Actions
Failure
…kwier/windows-zip-fix
dzsquared
temporarily deployed
to
Automation test
GitHub Actions
Inactive
dzsquared
temporarily deployed
to
Automation test
GitHub Actions
Inactive
dzsquared
temporarily deployed
to
Automation test
GitHub Actions
Inactive
dzsquared
temporarily deployed
to
Automation test
GitHub Actions
Inactive
dzsquared
temporarily deployed
to
Automation test
GitHub Actions
Inactive
dzsquared
temporarily deployed
to
Automation test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of environment variations for Windows runners leads to fractured pathways to unzip go-sqlcmd: https://github.com/actions/toolkit/blob/1f4b3fac06b689186037c0a52e1e876e18de521d/packages/tool-cache/src/tool-cache.ts#L354
As a result, the upstream has a few open issues related to unzip on Windows:
By enforcing the zip extension for the temporary file on Windows, we're guaranteeing that the unzip option works regardless of PS and .NET versions.
Fixes #149