Skip to content

Conversation

@JoshFieldstad
Copy link

No description provided.

@JoshFieldstad
Copy link
Author

@microsoft-github-policy-service agree

@JoshFieldstad
Copy link
Author

@zijchen FYI I am doing some testing on my side and after reviewing old PR's discovered that main.js needed to be recompiled when updating *.ts files. I ran

npm install
npm run build

and committed the result, if needed I am happy to revert this change or redo it using proper process. Thank you!

@dzsquared
Copy link
Collaborator

@JoshFieldstad - it looks like you will need to resolve the conflict on main.js (either revert the build or pull in the previous changes from the default branch)

This reverts commit 94302a6.
@JoshFieldstad
Copy link
Author

@dzsquared I reverted the change to main.js. What do you need from me on that main.js? Should I just leave it alone and let a pipeline or other process update it? Or is there something I should do?

Thanks!

@dzsquared
Copy link
Collaborator

@JoshFieldstad - usually you'd need to build main.js after having pulled in any recent changes from the default branch (it just so happens I merged to master this morning while you were working on this) - but I'm about to do a release and will open another PR with main.js built and some docs changes so no need for you to worry about it today :)

@dzsquared dzsquared merged commit dff2eda into Azure:master Feb 21, 2023
@JoshFieldstad
Copy link
Author

@dzsquared Thank you sir!

dzsquared added a commit that referenced this pull request Feb 22, 2023
dzsquared added a commit that referenced this pull request Feb 22, 2023
* add tests for #167

* docs update

* run build
@JoshFieldstad JoshFieldstad deleted the patch-1 branch February 22, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants