Update go-sqlcmd to v0.9.1 #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use tedious mssql library instead of sqlcmd * Fix mssql connection * Fix SqlUtils tests * Use config instead of connection string * Replace conn string builder with mssql config * Connect to master db * Restore connection string validation regex * PR comments, fix error handling * Update main.js * Use try catch for error handling * Fix typo
zijchen
commented
Oct 7, 2022
| connection-string: '${{ secrets[matrix.connection_string_secret] }}Initial Catalog=master;' | ||
| path: ${{ runner.temp }}/cleanup.sql | ||
| path: ./__testdata__/cleanup.sql | ||
| arguments: '-v DbName="${{ env.TEST_DB }}"' |
Contributor
Author
There was a problem hiding this comment.
This version fixes microsoft/go-sqlcmd#114 which lets us use SQLCMD variables here again
Contributor
Author
|
Submitted microsoft/go-sqlcmd#145 to see if we can get a 'latest' tag from go-sqlcmd |
zijchen
requested review from
Benjin,
chlafreniere,
kisantia,
llali and
ssreerama
chlafreniere
approved these changes
Oct 7, 2022
kisantia
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update go-sqlcmd to latest release for bug fixes