migrate to track2 azure go sdk #23
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to the latest version of Azure SDK for Go (known as track2), as old version of Azure SDK for go (known as track1) is deprecated and no longer recieving support.
as resource sku definitions in track1 and track2 are different, I made some necessary breaking changes:
armcompute.ResourceSKUsClient
instead ofcompute.ResourceSkusClient
, ininterface.go
,client.go
,cache.go
armcompute.ResourceSKU
instead ofcompute.ResourceSku
, insku.go
,wrap.go
as track2 List returns []* instead of [], and some properties use []* instead of *[], I changed some usages (for example, nil check) of those models.
I don't change SKU here, so SKU is not pointer and data is still []SKU but not []*armcompute.ResourceSKU, which might be different from sdk pattern.
github.com/Azure/skewer
togithub.com/Azure/skewer/v2
, ingo.mod
it's useless and not easy to keep both v1 and v2 version here, so I would like to migrate the whole package to v2. (maybe we can use another branch but use v2 tag, then we can use both v1 or v2 skewer)