demo: capability matching on vm sizes #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #12 +/- ##
==========================================
+ Coverage 71.58% 72.40% +0.81%
==========================================
Files 5 6 +1
Lines 278 308 +30
==========================================
+ Hits 199 223 +24
- Misses 79 85 +6
Continue to review full report at Codecov.
|
alexeldeib
commented
Jul 28, 2022
| t.Errorf("expected to find virtual machine sku standard_d4s_v3") | ||
| } | ||
|
|
||
| match := Match(ctx, cache, &sku, "eastus") |
There was a problem hiding this comment.
this currently returns zero matches because == is too strict on capabilities, but you get the idea..
alexeldeib
commented
Jul 28, 2022
| } | ||
|
|
||
| var capabilitiesToIgnore = map[string]bool{ | ||
| MaxResourceVolumeMB: true, |
There was a problem hiding this comment.
tried ignoring some, just fails matching different capabilities :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.