Hotfix/devcenter #811
Open
Hotfix/devcenter #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 22 commits
August 13, 2025 11:01
…and access policies
…ncluding new client ID and DevOps infrastructure object ID, and improve validation for subscription IDs.
…ev Center deployment
… lifecycle rules and adjusting role definitions for improved clarity and functionality.
…one link to prevent unnecessary resource creation.
…rce group name, and simplify additional network ID assignment.
…vider version to 4.39.0
…ling for improved clarity and functionality
…tion for service principal and subscription IDs, and update resource key handling for improved clarity and functionality.
…cy and improve readability across multiple scripts, and add control plane and workload zone name extraction from tfstate keys in relevant scripts.
- Updated debug mode checks to use lowercase 'true' for consistency. - Removed unnecessary exit on error in debug mode. - Enhanced argument parsing in various scripts to include new options for GitHub and DevOps. - Modified Terraform output handling to ensure correct variable assignments. - Added new environment variable exports for application configuration and key vault details. - Adjusted error handling and output logging for Terraform commands. - Streamlined the removal process in the remover scripts, including retry logic for destroy operations. - Cleaned up commented-out code and improved overall script structure for better maintainability.
…er handling of firewall_id in variables_local.tf
- Updated output values in output.tf to use trimspace for user_keyvault_id. - Added new output for spn_credential_vault_id in output.tf. - Enhanced provider configurations in providers.tf to use coalesce for subscription and client details. - Added validation for subscription_id and management_subscription_id in tfvar_variables.tf. - Set default values for public_network_access_enabled and enable_rbac_authorization_for_keyvault variables. - Improved validation for resourcegroup_arm_id and user_assigned_identity_id variables. - Adjusted workload_zone_name local variable formatting in variables_local.tf. - Corrected export_policy_rule configuration in anf.tf for NetApp volumes. - Updated dependencies for virtual network peering resources in infrastructure.tf. - Added dependencies for key vault secrets in iscsi.tf to ensure proper role assignment. - Refined key vault resource configurations in key_vault_sap_landscape.tf to use key_vault object for properties. - Modified role assignment conditions in role_assignments.tf to check for deployer_uai presence. - Reduced wait time for private endpoints in storage_accounts.tf and updated dependencies to use triggers. - Removed unnecessary variables related to key vault purge control and RBAC authorization in variables_global.tf.
…ity and reduce redundancy
…D functionality - Updated LandscapeModel and SystemModel to include custom_random_id property. - Modified LandscapeController and SystemController to generate custom_random_id if not provided. - Enhanced validation logic in CustomValidators to support array inputs. - Updated EnvironmentModel to reflect new variable names and structures. - Adjusted views for Environment creation and editing to accommodate new model properties. - Added new parameters for custom_random_id in JSON configuration files. - Updated project dependencies to latest versions for Azure SDK packages.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
deploy/terraform/terraform-units/modules/sap_landscape/key_vault_sap_landscape.tf
Dismissed
Show dismissed
Hide dismissed
…nsible installation
…e dns and storage
…m installer script
…in Terraform scripts
…m installer script
…references and streamline subscription ID retrieval.
… sap_library configurations for compatibility.
…user existence and improve error handling in local variable definitions.
…ify secret retrieval logic by adjusting dependencies.
…ope based on user existence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a mix of code style improvements, refactoring, and new logic.