Skip to content

Adding a warning for a continue-as-new call on a failed orchestration #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sophiatev merged 3 commits into from
Oct 30, 2025
Merged

Adding a warning for a continue-as-new call on a failed orchestration #1260

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6574247
first commit
Oct 28, 2025
b94e9b2
fixing a typo
Oct 28, 2025
f7c2e5b
addressing PR comment
Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/DurableTask.Core/TaskOrchestrationContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,6 +709,15 @@ public void CompleteOrchestration(string result, string details, OrchestrationSt
}
else
{
if (this.continueAsNew != null && orchestrationStatus == OrchestrationStatus.Failed)
{
TraceHelper.TraceSession(
TraceEventType.Warning,
"TaskOrchestrationContext-ContinueAsNewForFailedOrchestration",
OrchestrationInstance.InstanceId,
"Continue as new called for a failed orchestration, orchestration will complete");
}

if (this.executionCompletedOrTerminated)
{
return;
Expand Down
Loading