Skip to content

Conversation

@shenglol
Copy link
Contributor

@shenglol shenglol commented Oct 30, 2025

Updated BicepDefinitionHandler to handle UsingDeclarationSyntax, ensuring that Bicep source files instead of ARM template files for remote modules are opened (if Bicep source is available). This aligns the user experience with the behavior of Go to Definition for module paths in Bicep files.

Closes #17859.

Microsoft Reviewers: Open in CodeFlow

@shenglol shenglol force-pushed the shenglol/f12-for-bicepparam-using branch from 18c3810 to 9e58049 Compare October 30, 2025 17:11
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025

Test this change out locally with the following install scripts (Action run 18951564332)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 18951564332
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 18951564332"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 18951564332
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 18951564332"

@shenglol shenglol enabled auto-merge (squash) October 30, 2025 17:37
@github-actions
Copy link
Contributor

Dotnet Test Results

    96 files   -     48      96 suites   - 48   40m 42s ⏱️ - 24m 24s
12 525 tests  -     13  12 525 ✅  -     13  0 💤 ±0  0 ❌ ±0 
28 795 runs   - 14 391  28 795 ✅  - 14 391  0 💤 ±0  0 ❌ ±0 

Results for commit 9e58049. ± Comparison against base commit eb45f4e.

This pull request removes 1950 and adds 661 tests. Note that renamed tests count towards both.

		nestedProp1: 1
		nestedProp2: 2
		prop1: true
		prop2: false
	1
	2
	\$'")
	prop1: true
	prop2: false
…
Bicep.Cli.UnitTests.Services.ReplEnvironmentTests ‑ ShouldSubmitBuffer_terminates_at_expected_point ("var foo = {
")
Bicep.Cli.UnitTests.Services.ReplEnvironmentTests ‑ ShouldSubmitBuffer_terminates_at_expected_point ("var multilineString = '''
Line 1
Line 2
Line 3
'''")
Bicep.Cli.UnitTests.Services.ReplEnvironmentTests ‑ ShouldSubmitBuffer_terminates_at_expected_point ("var outRoleAssignments object[] = union(map(
  filter(varMockedEntraGroupIds, item => !contains(item.uniqueName, 'DevOps')),
  group => {
    principalId: group.groupId
    definition: group.roleToAssign
    relativeScope: ''
    principalType: 'Group'
  }
),[
  {
    principalId: '22222222-2222-2222-2222-222222222222'
    definition: 'Reader'
    relativeScope: ''
    principalType: 'ServicePrincipal'
  }
])")
Bicep.Cli.UnitTests.Services.ReplEnvironmentTests ‑ ShouldSubmitBuffer_terminates_at_expected_point ("var test = {
  abc: 'def' // boo
}")
Bicep.Cli.UnitTests.Services.ReplEnvironmentTests ‑ ShouldSubmitBuffer_terminates_at_expected_point ("var varMockedEntraGroupIds = [
  {
    uniqueName: 'Reader-Group'
    roleToAssign: 'Reader'
    groupId: '11111111-1111-1111-1111-111111111111'
  }
  {
    uniqueName: 'Contributor-Group'
    roleToAssign: 'Contributor'
    groupId: '22222222-2222-2222-2222-222222222222'
  }
  {
    uniqueName: 'DevOps-Group'
    groupId: '33333333-3333-3333-3333-333333333333'
  }
]")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
�Խ
�0\u0010\u0007��}
� ޅKb\u0007wǾBh�~`,\u001a�P��=�B\u0007���B�\u001b\u0013�\r�#ӝ��\u001dʦ�[�(�bn�\u000c���\u00005
�/ �jm�H��;\u0019ѵ�5��\u0012g� �%.��2Gk0#�\u0011$π(�
��'�0��p�;�����s[����*X��Ѩ��}�>�\u001f@	�\u0003\u0000�\u0002\u0002��G���E2����?�� ��(Z�\u0013�Q�h\u0000\u000c\u0000\u0000,"The path: index.json was not found in artifact contents")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
��K
�0\u0010\u0006�=E�\u0001�L��\u0015ܻ\u0011�x�hGTl�6B@���Bܴ��\u000f0�23�Ʉ_�����\u0016T7"ש\u001c\u000b64\u0008����-\u000c54\u000f��(
�q?�$\u001d.��u\u0018�\u0013w���p��%��h�H�0\u0013\u0006ri&�P���0�g�v�}U�\u0017��T��eO���\u0018�{�����*����+\u00040)HD\u0006Zei��G2�����dU�?��Q��rMu2�[{l���٢(����\u0003���\u0002\u0000\u000c\u0000\u0000,"Value cannot be null. (Parameter 'source')")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
���\u000b�0\u0014\u0007��+�?`�����C�!#,\u0008���A\u0006Z���?�<D\u0017��Z�>ǽ\u0007{��\u000e{;լ�JuY�PP�a44b\u0008�:�[�$\u0002�B\u0010�\�\u00089���t�W�*�(S���h�:�u\u0004R@�8\u0007\u001f\u000b)\u0002\u0000:3�S_
B��s�\u0015�n�\u0016m{����cZ=��7�\u0015}�?�\u000c\u0001\u0007B$%\u000c\u0000\u0011�}0��$�����\u001b'��&^\u001e��m��\u001d�\u0003�{&˲,k|O\u0011�*�\u0000\u000c\u0000\u0000,"'7' is an invalid end of a number. Expected a delimiter. Path: $.INVALID_JSON | LineNumber: 0 | BytePositionInLine: 20.")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000\u0003��K
�0\u0010\u0006�=EO�Τy���]z��\u0001\u001f4�6łxwӅ�"�Mm\u0004�-3\u000c3!���N�[�\u000f��i!e�S�4�$���	
$�^��\u0012\u0012	���7	\u0018z�;��\u001a�~\u0010+3�N��QI,�(���B\u0010����~���U�c=؋mo����N
�\C�&A����\u0019��\u000f���\u0003\u0000\u0014\u0003���(|�W�������A�$I\u0012�\u0013N���\u0000\u000c\u0000\u0000,"The path: index.json was not found in artifact contents")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000\u0003��K
�0\u0010\u0006�=E�\u0001bҼZ�{7�\u001b\u000f\u0010�\u0011+���BA���Bܴ��C0�230\u0013�\u001f�ޛv\u000b&��\u0012�T�&hl�QB��w�Ј�7���J!���7�q����*s��Aa�M�\u0017�0�X$$\u0017�D�S�����C5\u0016��4�$/3h���ʮ�\u0018j_��ހ��M7�[�)\u0017�IF�\u000e�_�\u0010U��.��d������������l\u0007�\u0011�`�O�j��n��y�t^ :�U\u0000\u000c\u0000\u0000,"Value cannot be null. (Parameter 'source')")
…

@shenglol shenglol merged commit 8ea021c into main Oct 30, 2025
42 checks passed
@shenglol shenglol deleted the shenglol/f12-for-bicepparam-using branch October 30, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Different experience for pressing F12 in VS in bicepparam and bicep files

3 participants