Skip to content

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Aug 25, 2025

The GH CLI appears to hang if a runId isn't provided - this PR just adds an explicit check for it

Copy link
Contributor

github-actions bot commented Aug 25, 2025

Test this change out locally with the following install scripts (Action run 17224291347)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 17224291347
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 17224291347"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 17224291347
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 17224291347"

Copy link
Contributor

github-actions bot commented Aug 25, 2025

Dotnet Test Results

   15 files   -    120     15 suites   - 120   3m 55s ⏱️ - 58m 32s
6 729 tests  -  5 556  6 729 ✅  -  5 556  0 💤 ±0  0 ❌ ±0 
8 843 runs   - 33 604  8 843 ✅  - 33 604  0 💤 ±0  0 ❌ ±0 

Results for commit 2a8a5a0. ± Comparison against base commit 034413c.

This pull request removes 7254 and adds 456 tests. Note that renamed tests count towards both.

		nestedProp1: 1
		nestedProp2: 2
		prop1: true
		prop2: false
	1
	2
	\$'")
	prop1: true
	prop2: false
…
Bicep.Core.UnitTests.Configuration.ConfigurationManagerTests ‑ GetConfiguration_InvalidCurrentCloudProfile_PropagatesConfigurationDiagnostic ("{
  "cloud": {
    "currentProfile": "MyCloud"
  }
}","The cloud profile "MyCloud" does not exist. Available profiles include "AzureChinaCloud", "AzureCloud", "AzureUSGovernment".")
Bicep.Core.UnitTests.Configuration.ConfigurationManagerTests ‑ GetConfiguration_InvalidCurrentCloudProfile_PropagatesConfigurationDiagnostic ("{
  "cloud": {
    "currentProfile": "MyCloud",
    "profiles": {
      "MyCloud": {
        "resourceManagerEndpoint": "Not and URL"
      }
    }
  }
}","The cloud profile "MyCloud" is invalid. The value of the "resourceManagerEndpoint" property "Not and URL" is not a valid URL.")
Bicep.Core.UnitTests.Configuration.ConfigurationManagerTests ‑ GetConfiguration_InvalidCurrentCloudProfile_PropagatesConfigurationDiagnostic ("{
  "cloud": {
    "currentProfile": "MyCloud",
    "profiles": {
      "MyCloud": {
        "resourceManagerEndpoint": "https://example.invalid"
      }
    }
  }
}","The cloud profile "MyCloud" is invalid. The "activeDirectoryAuthority" property cannot be null or undefined.")
Bicep.Core.UnitTests.Configuration.ConfigurationManagerTests ‑ GetConfiguration_InvalidCurrentCloudProfile_PropagatesConfigurationDiagnostic ("{
  "cloud": {
    "currentProfile": "MyCloud",
    "profiles": {
      "MyCloud": {
        "resourceManagerEndpoint": "https://example.invalid",
        "activeDirectoryAuthority": "Not an URL"
      }
    }
  }
}","The cloud profile "MyCloud" is invalid. The value of the "activeDirectoryAuthority" property "Not an URL" is not a valid URL.")
Bicep.Core.UnitTests.Configuration.ConfigurationManagerTests ‑ GetConfiguration_InvalidCurrentCloudProfile_PropagatesConfigurationDiagnostic ("{
  "cloud": {
    "currentProfile": "MyCloud",
    "profiles": {
      "MyCloud": {
      }
    }
  }
}","The cloud profile "MyCloud" is invalid. The "resourceManagerEndpoint" property cannot be null or undefined.")
Bicep.Core.UnitTests.Configuration.ConfigurationManagerTests ‑ GetConfiguration_InvalidUserAssignedIdentityOptions_PropagatesConfigurationDiagnostic ("{
  "cloud": {
    "credentialOptions": {
        "managedIdentity": {
            "type": "UserAssigned"
        }
    }
  }
}","The managed-identity configuration is invalid. Either "clientId" or "resourceId" must be set for user-assigned identity.")
Bicep.Core.UnitTests.Configuration.ConfigurationManagerTests ‑ GetConfiguration_InvalidUserAssignedIdentityOptions_PropagatesConfigurationDiagnostic ("{
  "cloud": {
    "credentialOptions": {
        "managedIdentity": {
            "type": "UserAssigned",
            "clientId": "foo"
        }
    }
  }
}","The managed-identity configuration is invalid. "clientId" must be a GUID.")
Bicep.Core.UnitTests.Configuration.ConfigurationManagerTests ‑ GetConfiguration_InvalidUserAssignedIdentityOptions_PropagatesConfigurationDiagnostic ("{
  "cloud": {
    "credentialOptions": {
        "managedIdentity": {
            "type": "UserAssigned",
            "clientId": "foo",
            "resourceId": "bar"
        }
    }
  }
}","The managed-identity configuration is invalid. "clientId" and "resourceId" cannot be set at the same time for user-assigned identity.")
Bicep.Core.UnitTests.Configuration.ConfigurationManagerTests ‑ GetConfiguration_InvalidUserAssignedIdentityOptions_PropagatesConfigurationDiagnostic ("{
  "cloud": {
    "credentialOptions": {
        "managedIdentity": {
            "type": "UserAssigned",
            "resourceId": "bar"
        }
    }
  }
}","The managed-identity configuration is invalid. "resourceId" must be a valid Azure resource identifier.")
Bicep.Core.UnitTests.Diagnostics.DiagnosticBuilderTests ‑ MissingTypePropertiesHasFix ("
                 resource appService 'Microsoft.Web/serverFarms@2020-06-01' = {
                       sku: {

                         name: 'D1'

                       }
                       // comment
                 }","
                 resource appService 'Microsoft.Web/serverFarms@2020-06-01' = {
                       sku: {

                         name: 'D1'

                       }
                       
                       location:
                       name:// comment
                 }")
…

♻️ This comment has been updated with latest results.

@anthony-c-martin anthony-c-martin changed the title Nightly installers - add error handling for missing run Nightly installers - avoid hanging if there's no valid run found Aug 25, 2025
@anthony-c-martin anthony-c-martin enabled auto-merge (squash) August 26, 2025 00:24
@anthony-c-martin anthony-c-martin merged commit 0746ab1 into main Aug 26, 2025
125 of 128 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/fix_installers branch August 26, 2025 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants