-
Notifications
You must be signed in to change notification settings - Fork 786
Nightly installers - avoid hanging if there's no valid run found #17901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedeca4
to
2a8a5a0
Compare
Test this change out locally with the following install scripts (Action run 17224291347) VSCode
Azure CLI
|
Dotnet Test Results 15 files - 120 15 suites - 120 3m 55s ⏱️ - 58m 32s Results for commit 2a8a5a0. ± Comparison against base commit 034413c. This pull request removes 7254 and adds 456 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
968392a
to
2a8a5a0
Compare
shenglol
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GH CLI appears to hang if a runId isn't provided - this PR just adds an explicit check for it