-
Notifications
You must be signed in to change notification settings - Fork 786
Bug fixes for moduleExtensionConfigs experimental feature. #17860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test this change out locally with the following install scripts (Action run 17249556358) VSCode
Azure CLI
|
Dotnet Test Results 90 files - 45 90 suites - 45 37m 36s ⏱️ - 24m 51s Results for commit 21c59df. ± Comparison against base commit 034413c. This pull request removes 1912 and adds 679 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
shenglol
reviewed
Aug 26, 2025
shenglol
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
extensionConfigs
property must be assigned an object literal. The properties of that object, which are extension aliases, must also be assigned object literals or use extension config inheritance expressions. This is so the language expressions result in the right structure expected by the API. This is needed because of the extra object layer of "value" vs "keyVaultReference".Example Usage
Checklist
Microsoft Reviewers: Open in CodeFlow