-
Notifications
You must be signed in to change notification settings - Fork 786
Linter rule should exclude all metadata #17667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linter rule should exclude all metadata #17667
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #17667 +/- ##
===========================================
- Coverage 94.28% 9.37% -84.91%
===========================================
Files 1113 7 -1106
Lines 100791 288 -100503
Branches 8734 123 -8611
===========================================
- Hits 95028 27 -95001
+ Misses 4595 260 -4335
+ Partials 1168 1 -1167
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
May I get a review on this please? |
src/Bicep.Core/Analyzers/Linter/Rules/NoHardcodedEnvironmentUrlsRule.cs
Outdated
Show resolved
Hide resolved
src/Bicep.Core/Analyzers/Linter/Rules/NoHardcodedEnvironmentUrlsRule.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay reviewing!
Done, thanks! Review again please |
May I get a review on this PR please? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When PRs are usually merged? Just to know if there are any schedules between versions, since this PR is opened for 1 month almost. Thanks for approving btw! |
No problem. It seems @anthony-c-martin needs to approve as well to unblock merging. @anthony-c-martin would you mind taking another look? |
Test this change out locally with the following install scripts (Action run 17224251071) VSCode
Azure CLI
|
Description
Fixes #10308
Checklist
Microsoft Reviewers: Open in CodeFlow