Skip to content

Conversation

guimatheus92
Copy link
Contributor

@guimatheus92 guimatheus92 commented Jul 27, 2025

Description

Fixes #10308

Checklist

Microsoft Reviewers: Open in CodeFlow

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 9.37%. Comparing base (108d816) to head (d0dddae).
⚠️ Report is 2904 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (108d816) and HEAD (d0dddae). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (108d816) HEAD (d0dddae)
dotnet 4 0
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #17667       +/-   ##
===========================================
- Coverage   94.28%    9.37%   -84.91%     
===========================================
  Files        1113        7     -1106     
  Lines      100791      288   -100503     
  Branches     8734      123     -8611     
===========================================
- Hits        95028       27    -95001     
+ Misses       4595      260     -4335     
+ Partials     1168        1     -1167     
Flag Coverage Δ
dotnet ?
typescript 9.37% <ø> (+1.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1102 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@guimatheus92
Copy link
Contributor Author

May I get a review on this please?

Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay reviewing!

@guimatheus92
Copy link
Contributor Author

Sorry for the delay reviewing!

Done, thanks! Review again please

@guimatheus92
Copy link
Contributor Author

May I get a review on this PR please? Thanks

Copy link
Contributor

@shenglol shenglol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@guimatheus92
Copy link
Contributor Author

When PRs are usually merged? Just to know if there are any schedules between versions, since this PR is opened for 1 month almost. Thanks for approving btw!

@shenglol
Copy link
Contributor

When PRs are usually merged? Just to know if there are any schedules between versions, since this PR is opened for 1 month almost. Thanks for approving btw!

No problem. It seems @anthony-c-martin needs to approve as well to unblock merging. @anthony-c-martin would you mind taking another look?

@anthony-c-martin anthony-c-martin merged commit e138b17 into Azure:main Aug 26, 2025
41 checks passed
Copy link
Contributor

Test this change out locally with the following install scripts (Action run 17224251071)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 17224251071
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 17224251071"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 17224251071
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 17224251071"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linter rule should not trigger on description field
4 participants