-
Notifications
You must be signed in to change notification settings - Fork 786
fix and add test for invalid parameter type #17193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix and add test for invalid parameter type #17193
Conversation
Test this change out locally with the following install scripts (Action run 16978588431) VSCode
Azure CLI
|
Dotnet Test Results 90 files - 45 90 suites - 45 36m 47s ⏱️ - 20m 7s Results for commit 820a376. ± Comparison against base commit 3f35b0e. This pull request removes 1911 and adds 654 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
…smatch-for-extendable-bicepparam-values
…smatch-for-extendable-bicepparam-values
…smatch-for-extendable-bicepparam-values
…source file check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an issue where type mismatches between parameters in Bicep files and their corresponding values in bicepparam files were not being properly validated. The fix adds diagnostic error reporting when parameter types don't match across these file boundaries.
- Extends type validation to check parameter assignments from external files (bicepparam files)
- Adds diagnostic error reporting for type mismatches between bicep and bicepparam files
- Includes comprehensive test coverage for both single and multiple type mismatch scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/Bicep.Core/Semantics/SemanticModel.cs | Extends type validation logic to handle cross-file parameter assignments and emit appropriate diagnostics |
src/Bicep.Cli.IntegrationTests/BuildParamsCommandTests.cs | Adds integration tests to verify error reporting for type mismatches in extended bicepparam files |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Fixes #16731
Adding diagnostic error when there is a type mismatch between the parameter in the bicep file and the parameter in the bicepparam file.
Also adding a test to verify the error message is correct
Microsoft Reviewers: Open in CodeFlow